Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

redwax-modules: 0.2.1 -> 0.2.2/0.2.3 #80182

Merged
merged 1 commit into from Feb 23, 2020
Merged

redwax-modules: 0.2.1 -> 0.2.2/0.2.3 #80182

merged 1 commit into from Feb 23, 2020

Conversation

dirkx
Copy link
Contributor

@dirkx dirkx commented Feb 15, 2020

Update redwax modules to most recent versions; also removes the compatibility stub as it is no longer needed.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dirkx dirkx requested a review from aanderse February 16, 2020 09:57
@aanderse
Copy link
Member

@dirkx nice cleanup, looking good 👍

Please squash commits and set the commit message to something like redwax-modules: 0.2.1 -> 0.2.2/0.2.3. Ideally this PR would be a commit per package update with each commit having a message following the CONTRIBUTING.MD guidelines, such as apacheHttpdPackages.mod_ca: 0.2.1 -> 0.2.2. Something to keep in mind for future updates.

@dirkx
Copy link
Contributor Author

dirkx commented Feb 18, 2020 •
edited

Ok - done that.

@aanderse
Copy link
Member

aanderse commented Feb 22, 2020 •
edited

@GrahamcOfBorg build apacheHttpdPackages.mod_ca apacheHttpdPackages.mod_crl apacheHttpdPackages.mod_csr apacheHttpdPackages.mod_ocsp apacheHttpdPackages.mod_pkcs12 apacheHttpdPackages.mod_scep apacheHttpdPackages.mod_spkac apacheHttpdPackages.mod_timestamp

@aanderse aanderse changed the title redwax-modules 0.2.1 -> 0.2.2/0.2.3 redwax-modules: 0.2.1 -> 0.2.2/0.2.3 Feb 23, 2020
@aanderse aanderse merged commit fc7efd5 into NixOS:master Feb 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse Awaiting requested review from aanderse

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dirkx @aanderse