Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.openapi-spec-validator: add setuptools #80129

Merged
merged 1 commit into from Feb 14, 2020
Merged

python3Packages.openapi-spec-validator: add setuptools #80129

merged 1 commit into from Feb 14, 2020

Conversation

disassembler
Copy link
Member

@disassembler disassembler commented Feb 14, 2020 •
edited

Motivation for this change

Fails to run:

openapi-spec-validator --help
Traceback (most recent call last):
  File "/nix/store/1kqp8dslskvhzj60y4h13hf3ys5ha11p-python3.7-openapi-spec-validator-0.2.8/bin/.openapi-spec-validator-wrapped", line 6, in <module>
    from openapi_spec_validator.__main__ import main
  File "/nix/store/1kqp8dslskvhzj60y4h13hf3ys5ha11p-python3.7-openapi-spec-validator-0.2.8/lib/python3.7/site-packages/openapi_spec_validator/__init__.py", line 6, in <module>
    from openapi_spec_validator.schemas import get_openapi_schema
  File "/nix/store/1kqp8dslskvhzj60y4h13hf3ys5ha11p-python3.7-openapi-spec-validator-0.2.8/lib/python3.7/site-packages/openapi_spec_validator/schemas.py", line 4, in <module>
    from pkg_resources import resource_filename
ModuleNotFoundError: No module named 'pkg_resources'
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@disassembler disassembler added 6.topic: python 9.needs: port to stable A PR needs a backport to the stable release. labels Feb 14, 2020
worldofpeace
worldofpeace approved these changes Feb 14, 2020
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The help menu worked for me.

@worldofpeace worldofpeace merged commit 62a7f80 into NixOS:master Feb 14, 2020
@worldofpeace
Copy link
Contributor

20.03 63772f7

@worldofpeace
Copy link
Contributor

19.09 492d1a2

@worldofpeace worldofpeace added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Feb 14, 2020
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Feb 14, 2020
@worldofpeace @dtzWill
Merge pull request NixOS#80129 from disassembler/openapi-spec-validator
efdff2e 
python3Packages.openapi-spec-validator: add setuptools

(cherry picked from commit 62a7f80)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: port to stable A PR already has a backport to the stable release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@disassembler @worldofpeace