Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.babelgladeextractor: disable for python2 #80189

Merged
merged 1 commit into from Feb 15, 2020
Merged

pythonPackages.babelgladeextractor: disable for python2 #80189

merged 1 commit into from Feb 15, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Feb 15, 2020 •
edited

Motivation for this change

Uses python3 specific calls in setup.py:

  File "setup.py", line 23, in _slurp
    with open(path, encoding="utf-8") as fp:
TypeError: 'encoding' is an invalid keyword argument for this function
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
pythonPackages.babelgladeextractor: disable for python2
38285b5 
Uses python3 specific calls in setup.py:
```
  File "setup.py", line 23, in _slurp
    with open(path, encoding="utf-8") as fp:
TypeError: 'encoding' is an invalid keyword argument for this function
```
@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build pythonPackages.babelgladeextractor
@GrahamcOfBorg build python3Packages.babelgladeextractor

@jonringer jonringer merged commit 1037206 into NixOS:master Feb 15, 2020
@jonringer jonringer deleted the disable-py2-babel branch February 26, 2020 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jonringer