Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #6399: Create parent directories if they don't already exist #8003

Merged
merged 1 commit into from Feb 19, 2020

Conversation

LordAro
Copy link
Member

@LordAro LordAro commented Feb 15, 2020

I think ~/.local/share is special, in that it's the only 2-part personal directory where the parents haven't definitely been created already. So in this highly unlikely scenario where ~/.local/share doesn't exist, recursively try to create parents

Pretty sure I got all the pointers correct...

@James103
Copy link
Contributor

It looks like you are getting "can't open file openttd.exe" during the testing step on the checks. Why? Is it something to do with the changes made?

@glx22
Copy link
Contributor

glx22 commented Feb 15, 2020

Re-ran the failed checks. Seems they are failing again, I guess it's an infinite loop or something similar.

@LordAro
Copy link
Member Author

LordAro commented Feb 15, 2020

Damn. Curious that it's working on Linux...

Copy link
Contributor

@glx22 glx22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LordAro LordAro added the backport requested This PR should be backport to current release (RC / stable) label Feb 15, 2020
@nielsmh nielsmh merged commit 4bc7883 into OpenTTD:master Feb 19, 2020
@LordAro LordAro deleted the bug6399 branch February 29, 2020 11:10
@LordAro LordAro added backported This PR is backported to a current release (RC / stable) and removed backport requested This PR should be backport to current release (RC / stable) labels Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported This PR is backported to a current release (RC / stable)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants