Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: solvespace/solvespace
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: dcc80de73067
Choose a base ref
...
head repository: solvespace/solvespace
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: bae84b27e48e
Choose a head ref
  • 2 commits
  • 1 file changed
  • 1 contributor

Commits on Feb 14, 2020

  1. snap: Remove superfluous files from package 

    Remove all files from snap that are already included in the base snap
or in any connected content snaps.

The main advantage is the massively reduced snap size:
From ~70 MB down to ~6 MB.
    @ppd @whitequark
    ppd authored and whitequark committed Feb 14, 2020
    Copy the full SHA
    1cd727d View commit details

  2. snap: Fix missing extension for cli 

    solvespace-cli needs the gnome-3-28 extension to find its libraries.
    @ppd @whitequark
    ppd authored and whitequark committed Feb 14, 2020
    Copy the full SHA
    bae84b2 View commit details
Showing with 13 additions and 4 deletions.
  1. +13 −4 pkg/snap/snap/snapcraft.yaml
17 changes: 13 additions & 4 deletions pkg/snap/snap/snapcraft.yaml
View file
Original file line number Diff line number Diff line change
@@ -26,9 +26,10 @@ apps:
extensions: [gnome-3-28]
plugs: [opengl, unity7, home, removable-media, gsettings, network]
environment:
__EGL_VENDOR_LIBRARY_DIRS: $SNAP/usr/share/glvnd/egl_vendor.d
__EGL_VENDOR_LIBRARY_DIRS: $SNAP/gnome-platform/usr/share/glvnd/egl_vendor.d:$SNAP/usr/share/glvnd/egl_vendor.d
cli:
command: usr/bin/solvespace-cli
extensions: [gnome-3-28]
plugs: [home, removable-media, network]

parts:
@@ -71,6 +72,14 @@ parts:
- libglibmm-2.4-1v5
- libpangomm-1.4-1v5
- libsigc++-2.0-0v5
- libglew2.0
- libegl-mesa0
- libdrm2
cleanup:
after: [solvespace]
plugin: nil
build-snaps: [core18, gnome-3-28-1804]
override-prime: |
# Remove all files from snap that are already included in the base snap or in
# any connected content snaps
set -eux
for snap in "core18" "gnome-3-28-1804"; do # List all content-snaps and base snaps you're using here
cd "/snap/$snap/current" && find . -type f,l -exec rm -f "$SNAPCRAFT_PRIME/{}" \;
done