Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go_1_13: 1.13.7 -> 1.13.8, go_1_12: 1.12.16 -> 1.12.17 #80165

Merged
merged 3 commits into from Feb 16, 2020

Conversation

Frostman
Copy link
Member

@Frostman Frostman commented Feb 15, 2020

Motivation for this change

https://github.com/golang/go/releases/tag/go1.12.17
https://github.com/golang/go/releases/tag/go1.13.8

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This change is Reviewable

@Frostman
Copy link
Member Author

Frostman commented Feb 15, 2020

nixpkgs-review build 746 packages and 4 failed to build: blsd, gitAndTools.grv, gitaly, python38Packages.aria2p with unrelated reasons.

blsd, grv and gitaly failed b/c of the wrong libgit2 version, I'm currently investigating the reason for it, here is the example output:

builder for '/nix/store/sib6dszinjv8ycsmfdjz4rinn7vyirgj-blsd-2017-07-27.drv' failed with exit code 1; last 10 log lines:
  configuring
  unpacking source archive /nix/store/558shbs6cs1738fj6b4q0721z7276pnq-git2go-14280de
  building
  runtime/cgo
  net
  github.com/libgit2/git2go
  # github.com/libgit2/git2go
  go/src/github.com/libgit2/git2go/git_dynamic.go:10:3: error: #error "Invalid libgit2 version; this git2go supports libgit2 v0.27
"
     10 | # error "Invalid libgit2 version; this git2go supports libgit2 v0.27"
        |   ^~~~~

@Frostman Frostman changed the title Go bump go_1_13: 1.13.7 -> 1.13.8, go_1_12: 1.12.16 -> 1.12.17 Feb 15, 2020
@FRidh FRidh changed the base branch from master to staging February 16, 2020 07:55
@FRidh FRidh merged commit 02b0334 into NixOS:staging Feb 16, 2020
@Frostman
Copy link
Member Author

@FRidh how can I determine when such change should go to the staging instead of the master? thank you

@Frostman Frostman deleted the go-bump branch February 16, 2020 08:34
@FRidh
Copy link
Member

FRidh commented Feb 16, 2020

When there is more than 500 rebuilds, it should target staging.

When a PR is opened, you can have a look at the labels that ofborg placed. Offline you could do this with a tool such as nix-review.

@kalbasit
Copy link
Member

@FRidh I don't see a reason to merge it to staging first. Go packages are generally quick and as resource-intensive as other languages. I've been merging Go prs to master directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants