corrected postgresql support for gdal 3.0+ #80127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danbst
reviewed
Feb 14, 2020
jtojnar
reviewed
Feb 14, 2020
jtojnar
reviewed
Feb 14, 2020
jtojnar
reviewed
Feb 14, 2020
| "--with-expat=${expat.dev}" | ||
| "--with-jpeg=${libjpeg.dev}" | ||
| "--with-libtiff=${libtiff.dev}" # optional (without largetiff support) | ||
| "--with-png=${libpng.dev}" # optional | ||
| "--with-poppler=${poppler.dev}" # optional | ||
| "--with-libz=${zlib.dev}" # optional | ||
| "--with-pg=${postgresql}/bin/pg_config" | ||
| "--with-pg=yes" # since gdal 3.0 doesn't use ${postgresql}/bin/pg_config |
There was a problem hiding this comment.
There was some weird spacing.
Suggested change
| "--with-pg=yes" # since gdal 3.0 doesn't use ${postgresql}/bin/pg_config | |
| "--with-pg=yes" # since gdal 3.0 doesn't use ${postgresql}/bin/pg_config |
There was a problem hiding this comment.
For my local development I am using nixfmt (https://github.com/serokell/nixfmt), but I didn't want to change the whole file. Reading all of your comments seems like it is inevitable. I will do the adjustments tomorrow.
There was a problem hiding this comment.
Took me a lot of time. I had to actually undo all the commits and make it a new as the plugin I was using in VSCode was adding strange comments. Now it should be OK and all commits make sense.
brano543
force-pushed
the
master
branch
2 times, most recently
from
0c355e0
to
f012b14
Compare
|
thanks for your time!, so clear much ❤️ |
|
You are welcome. Thank you for dedicating time to this project. I really like it :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Configure parameters for PostgreSQL support in GDAL has changes since 3.0, see OSGeo/gdal#1657.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)