Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19.09] e2fsprogs: 1.45.3 -> 1.45.4 #77998

Merged
merged 1 commit into from Jan 19, 2020
Merged

[19.09] e2fsprogs: 1.45.3 -> 1.45.4 #77998

merged 1 commit into from Jan 19, 2020

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Jan 18, 2020

backport to 19.09, fixes CVE-2019-5094.
closes #70087

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@flokli flokli requested a review from delroth January 18, 2020 23:05
@flokli flokli mentioned this pull request Jan 18, 2020
Closed
1 task
@flokli flokli changed the title e2fsprogs: 1.45.3 -> 1.45.4 [19.09] e2fsprogs: 1.45.3 -> 1.45.4 Jan 18, 2020
delroth
delroth approved these changes Jan 18, 2020
View reviewed changes
Copy link
Contributor

@delroth delroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untested, but can confirm 1.45.4 has the CVE fix.

@ofborg ofborg bot requested a review from edolstra January 18, 2020 23:14
@flokli flokli changed the base branch from release-19.09 to staging-19.09 January 18, 2020 23:29
@r-ryantm @flokli
e2fsprogs: 1.45.3 -> 1.45.4
2a65776 
Semi-automatic update generated by
https://github.com/ryantm/nixpkgs-update tools. This update was made
based on information from
https://repology.org/metapackage/e2fsprogs/versions

(cherry picked from commit eff7a16)
@flokli
Copy link
Contributor Author

flokli commented Jan 18, 2020

Hm, this is a somewhat big rebuild. Changed base to staging-19.09, highlighting @NixOS/backports to make sure staging this will get it's way into the channels.

worldofpeace
worldofpeace approved these changes Jan 19, 2020
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just want to mention that the handling of the release staging branches seems to be completely voluntary.
And release-19.09 should probably be merged into it first.

@flokli
Copy link
Contributor Author

flokli commented Jan 19, 2020

@lheckemann @disassembler What do you propose doing here? Should I just merge it to release-19.09, or do you plan to do some staging round in the near future?

@worldofpeace
Copy link
Contributor

I've merged release-19.09 into staging-19.09 45931aa.
For what it's worth, if the CVE isn't high problematic let's just merge it to the staging release branch.

@flokli flokli merged commit 66098b5 into NixOS:staging-19.09 Jan 19, 2020
@flokli flokli deleted the 19.09-e2fsprogs-1.45.4 branch January 19, 2020 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delroth delroth delroth approved these changes

@worldofpeace worldofpeace worldofpeace approved these changes

@edolstra edolstra Awaiting requested review from edolstra

@disassembler disassembler Awaiting requested review from disassembler

@lheckemann lheckemann Awaiting requested review from lheckemann

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 11-100 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@flokli @worldofpeace @delroth @nh2 @r-ryantm