pythonPackages: add plexauth, plexapi, plexwebsocket
#78011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colemickens
commented
Jan 19, 2020
10 tasks
colemickens
force-pushed
the
nixpkgs-ha-pkgs-plex
branch
from
54f61c7
to
883c992
Compare
|
Two of these don't have any tests in their source. What is the convention for doCheck in that case? I left it in and set it to For Is this expected? Does that mean pytest runs them silently if they pass? Thanks for the info.... |
jonringer
reviewed
Jan 19, 2020
jonringer
reviewed
Jan 19, 2020
| propagatedBuildInputs = [ requests tqdm websocket_client ]; | ||
|
|
||
| doCheck = true; | ||
| checkInputs = [ pytest pillow ]; |
There was a problem hiding this comment.
or disable python2.7. I'm fine with either tbh
Suggested change
| checkInputs = [ pytest pillow ]; | |
| checkInputs = [ pytest pillow ] | |
| ++ lib.optionals isPy27 [ mock ]; |
builder for '/nix/store/babalivzngycash5y3vk2xra333q9cv1-python2.7-PlexAPI-3.2.0.drv' failed with exit code 1; last 10 log lines:
from mock import patch, MagicMock
ImportError: No module named mock
----------------------------------------------------------------------
Ran 7 tests in 0.000s
FAILED (errors=7)
Test failed: <unittest.runner.TextTestResult run=7 errors=7 failures=0>
error: Test failed: <unittest.runner.TextTestResult run=7 errors=7 failures=0>
|
So how do I disable packages for python2? All I can think of is adding the attribute to python3Packages instead of all python packages, but it seems like that would only be for a single python3 version instead all of the python3 versions which might be preferred? |
colemickens
force-pushed
the
nixpkgs-ha-pkgs-plex
branch
3 times, most recently
from
5a5e3f0
to
882f8c2
Compare
|
Cool. I figured it out from your other review. I assume that the disablement should propogate too? IE: if aiohttp is disabled in py27, then anything that uses it should also be explicitly disabled? That's what I did here for the two that use aiohttp. Thanks! Hopefully its good to go. |
|
if aiohttp is disabled, then this version will also be disabled |
jonringer
reviewed
Jan 21, 2020
colemickens
force-pushed
the
nixpkgs-ha-pkgs-plex
branch
from
882f8c2
to
b43ea90
Compare
|
Suggested changes applied. Thanks! |
jonringer
approved these changes
Jan 21, 2020
There was a problem hiding this comment.
diff LGTM
commits LGTM
python38 failures related to aiohttp package
[8 built (1 failed), 2 copied (0.5 MiB), 0.1 MiB DL]
error: build of '/nix/store/rjhi7a5gaxb9g514m4lxnip2lclbfbhj-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/78011
2 package failed to build:
python38Packages.plexauth python38Packages.plexwebsocket
5 package built:
python27Packages.plexapi python37Packages.plexapi python37Packages.plexauth python37Packages.plexwebsocket python38Packages.plexapi
|
@GrahamcOfBorg build python27Packages.plexapi python37Packages.plexapi python37Packages.plexauth python37Packages.plexwebsocket python38Packages.plexapi |
|
darwin builds are timing out, if it's broken, we will revisit it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
These are used by
home-assistantwhen theplexcomponent is used.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)