Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

home-assistant: v0.103.1 -> 0.104.3 #78010

Merged
merged 1 commit into from Jan 28, 2020
Merged

home-assistant: v0.103.1 -> 0.104.3 #78010

merged 1 commit into from Jan 28, 2020

Conversation

colemickens
Copy link
Member

@colemickens colemickens commented Jan 19, 2020 •
edited

Motivation for this change

Upgrade home-assistant from 0.103.1 -> 0.104.3.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@colemickens colemickens mentioned this pull request Jan 19, 2020
Closed
10 tasks
@ofborg ofborg bot requested review from globin and dotlambda January 19, 2020 08:19
@colemickens colemickens marked this pull request as ready for review January 19, 2020 09:12
@colemickens
Copy link
Member Author

This is ready for review. Please also take a look at : #78009

@colemickens
Copy link
Member Author

cc: @Mic92

@Mic92
Copy link
Member

Mic92 commented Jan 20, 2020

Works fine in general. It only breaks icloud support, which I added in #78109

@colemickens colemickens changed the title home-assistant: v0.103.1 -> 0.104.2 home-assistant: v0.103.1 -> 0.104.3 Jan 28, 2020
@colemickens
Copy link
Member Author

Now with 0.0.1 more umph - updated to latest release - 0.104.3.

@colemickens
Copy link
Member Author

@Mic92 Additionally, this no longer breaks your recently added iCloud support - I've updated, rebased, and regenerated.

@Mic92
Copy link
Member

Mic92 commented Jan 28, 2020 •
edited

@colemickens Ok. I cannot confirm that for me. I no longer see home-assistant icloud logins in the log after this update. I have not digged deeper into it. The rest seems to work. Maybe we could merge it anyway, it might be even a miss configuration on my site: home-assistant/core#31039 (comment)

@Mic92 Mic92 merged commit 610a8fd into NixOS:master Jan 28, 2020
@colemickens colemickens deleted the nixpkgs-ha-verbump branch January 30, 2020 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@globin globin Awaiting requested review from globin

@dotlambda dotlambda Awaiting requested review from dotlambda

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@colemickens @Mic92