Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.runway-python: 0.5.7 -> 0.5.9 #78035

Merged
merged 2 commits into from Jan 21, 2020
Merged

pythonPackages.runway-python: 0.5.7 -> 0.5.9 #78035

merged 2 commits into from Jan 21, 2020

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Jan 19, 2020 •
edited

Motivation for this change

Update to latest stable. Add new dependency Flask-Sockets.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jonringer
jonringer approved these changes Jan 21, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM

[7 built, 17 copied (47.7 MiB), 7.8 MiB DL]
https://github.com/NixOS/nixpkgs/pull/78035
4 package built:
python37Packages.flask-sockets python37Packages.runway-python python38Packages.flask-sockets python38Packages.runway-python

@jonringer
Copy link
Contributor

@GrahamcOfBorg build python37Packages.flask-sockets python37Packages.runway-python python38Packages.flask-sockets python38Packages.runway-python

@jonringer
Copy link
Contributor

darwin failure unrelated

@jonringer jonringer merged commit e86c8b6 into NixOS:master Jan 21, 2020
@prusnak prusnak deleted the runway-python branch January 21, 2020 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@prusnak @jonringer