Skip to content

solr: 8.4.0 -> 8.4.1 #77983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 25, 2020
Merged

solr: 8.4.0 -> 8.4.1 #77983

merged 3 commits into from
Jan 25, 2020
+56 −112

Conversation

aanderse
Copy link
Member

@aanderse aanderse commented Jan 18, 2020 •
edited
Loading

Motivation for this change

Version bump. The 8.x series has been out long enough and considered stable I don't need the 7.x series anymore. The transition from 7.x to 8.x is seamless.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jan 18, 2020
@ofborg ofborg bot requested a review from domenkozar January 18, 2020 14:12
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jan 18, 2020
@aanderse aanderse requested a review from srhb January 25, 2020 12:08
srhb
srhb approved these changes Jan 25, 2020
View reviewed changes
Copy link
Contributor

@srhb srhb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me! I don't use it myself, so I can't tell whether 7 will be missed. I will assume not. :)

@aanderse
Copy link
Member Author

@GrahamcOfBorg test solr

@aanderse aanderse merged commit 0e0b8f2 into NixOS:master Jan 25, 2020
@aanderse aanderse deleted the solr branch January 25, 2020 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srhb srhb

@domenkozar domenkozar

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aanderse @srhb