Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An inverse for Anticommutator #2451

Merged
merged 6 commits into from
Jan 18, 2020

Conversation

eggrobin
Copy link
Member

No description provided.

@@ -111,6 +111,16 @@ SymmetricBilinearForm<Scalar, Frame, Multivector>::Anticommutator() const {
matrix_.Trace() * R3x3Matrix<double>::Identity() - matrix_);
}

template<typename Scalar,
typename Frame,
template<typename, typename> typename Multivector>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are places in this file and others where you give names to the first two typenames thus: template<typename S, typename F> typename Multivector. Please change everything to be consistent.

I would personally favour dropping the S and F everywhere, but it's your call.

@pleroy pleroy added the LGTM label Jan 18, 2020
@eggrobin eggrobin changed the title Tensor contraction An inverse for Anticommutator Jan 18, 2020
@eggrobin eggrobin merged commit 311c757 into mockingbirdnest:master Jan 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants