nodePackages/ssb-room: init at 1.1.2 #78037
Conversation
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| {pkgs ? import <nixpkgs> { | |||
| inherit system; | |||
| }, system ? builtins.currentSystem, nodejs ? pkgs."nodejs-13_x"}: | |||
| }, system ? builtins.currentSystem, nodejs ? pkgs."nodejs-8_x"}: | |||
There was a problem hiding this comment.
Not sure why this got changed.
There was a problem hiding this comment.
node2nix is called with the --node-js-13 argument https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/node-packages/generate.sh#L10, which according to https://github.com/svanderburg/node2nix/blob/master/bin/node2nix.js#L134 is not implemented yet...
@marsam did you created this file manually? Is anything special preventing us to upstream that to node2nix?
There was a problem hiding this comment.
Created a proper issue to track that: #78044
There was a problem hiding this comment.
Created a proper issue to track that: #78044
There was a problem hiding this comment.
@marsam did you created this file manually?
yes, I remember changing this line with 13_x. Sorry about that!
There was a problem hiding this comment.
Sorry about that!
No problem :) Let's fix this 👍
| @@ -363,7 +363,7 @@ let | |||
|
|
|||
| npm ${forceOfflineFlag} --nodedir=${nodeSources} ${npmFlags} ${stdenv.lib.optionalString production "--production"} rebuild | |||
|
|
|||
| if [ "''${dontNpmInstall-}" != "1" ] | |||
| if [ "$dontNpmInstall" != "1" ] | |||
There was a problem hiding this comment.
This comes from a tree-wide change: 2811b03
It is to be expected.
@Ericson2314, this file has been auto-generated, should we upstream that to https://github.com/svanderburg/node2nix/blob/master/nix/node-env.nix#L366 ?
|
Please rework your PR. It now has a merge conflict after PR #89184 has been merged |
|
Closing, as I ended up not using this. |
|
If somebody want to take over this at some point: the ground work in node2nix has been done. More infos on #78044 |
Motivation for this change
Add ssb-room package.
Things done
Ran the
./generate.shscript after adding the package tonode-packages-v10.json.sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)/cc @NinjaTrappeur