Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VictoriaMetrics: init at v1.32.5, add module, tests #78038

Merged
merged 2 commits into from Jan 30, 2020
Merged

VictoriaMetrics: init at v1.32.5, add module, tests #78038

merged 2 commits into from Jan 30, 2020

Conversation

yorickvP
Copy link
Contributor

Motivation for this change

It turns out prometheus isn't good for long-term storage. I looked around and found VictoriaMetrics, which is better for my usecase.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@yorickvP yorickvP changed the title Victoriametrics Victoriametrics: init at v1.32.5, add module, tests Jan 19, 2020
@yorickvP yorickvP changed the title Victoriametrics: init at v1.32.5, add module, tests VictoriaMetrics: init at v1.32.5, add module, tests Jan 19, 2020
@yorickvP
Copy link
Contributor Author

@GrahamcOfBorg build victoriametrics

@yorickvP
Copy link
Contributor Author

@GrahamcOfBorg test victoriametrics

@ofborg ofborg bot requested a review from kalbasit January 19, 2020 18:07
infinisil
infinisil requested changes Jan 20, 2020
View reviewed changes
nixos/modules/services/databases/victoriametrics.nix Outdated Show resolved Hide resolved
nixos/modules/services/databases/victoriametrics.nix Outdated Show resolved Hide resolved
nixos/modules/services/databases/victoriametrics.nix Outdated Show resolved Hide resolved
nixos/modules/services/databases/victoriametrics.nix Outdated Show resolved Hide resolved
@yorickvP
Copy link
Contributor Author

Updated.

@infinisil
Copy link
Member

Looking good now, all that's left is to squash the commits a bit, I suggest one for the package addition and one for the module.

@yorickvP
Copy link
Contributor Author

Done

@infinisil infinisil merged commit 32718c9 into NixOS:master Jan 30, 2020
anna328p pushed a commit to anna328p/nixpkgs that referenced this pull request Feb 2, 2020
@infinisil @anna328p
VictoriaMetrics: init at v1.32.5, add module, tests (NixOS#78038)
e932daa 
VictoriaMetrics: init at v1.32.5, add module, tests
@infinisil infinisil mentioned this pull request Aug 25, 2020
Closed
@yorickvP yorickvP mentioned this pull request Sep 11, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil infinisil approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yorickvP @infinisil @kvtb