Pr scala out dir cleaned #78042
Merged
Pr scala out dir cleaned #78042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 19, 2020 19:32
Before, this package installed files called LICENSE and NOTICE at the profile root directory. Which conflicts with other packages with the same issue. Those files reside now in $out/share/doc/scala/.
Before, this package installed files called LICENSE and NOTICE at the profile root directory. Which conflicts with other packages with the same issue. Those files reside now in $out/share/doc/scala/.
Before, this package installed files called LICENSE and NOTICE at the profile root directory. Which conflicts with other packages with the same issue. Those files reside now in $out/share/doc/scala/.
|
Is there anything else I can do to simplify merging or reviewing that PR for others? |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The changed scala packages put text files like LICENCSE and NOTICE into their root directory. They should not be there to avoid clashes between packages.
Things done
Changed the install phase of scala, scala_2_12, and scala_2_11 to move those files to $out/share/doc/scala. scala_2_10 is unchanged since it has way more files in $out which should not be there imho. And I am not sure where to put them.
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)