pythonPackages.pycurl: Disable tests #78043
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infinisil
added
the
9.needs: port to stable
|
An attempt to fix the tests was made by @jonringer in #72039, but that failed due to more flakey tests. |
|
I would prefer to just disable the module, it's been a pain for the longest time, in which case I would prefer to do: #72039 |
|
Tests still help a lot when bumping dependencies |
|
fixed in 95e3e3e not sure why my PR doesn't show as merged |
|
fixed in 95e3e3e not sure why my PR doesn't show as merged, git hub is being weird |
|
Backport is needed still |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Tests are very flakey, disable them for now, fixes #77304
Ping @FRidh @costrouc
Things done
python{2,3}Packages.pycurlsuccessfully on NixOS