Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cross nixos aarch64 2018 08 05 #77999

Closed
wants to merge 5 commits into from
Closed

Cross nixos aarch64 2018 08 05 #77999

wants to merge 5 commits into from

Conversation

MarcFontaine
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danbst
Copy link
Contributor

danbst commented Feb 3, 2020

why is switch-to-configuration change reverted?

@samueldr
Copy link
Member

samueldr commented Feb 3, 2020

This looks like an accidental use of the "open PR" function from the branch of another user's fork.

I'll close this, assuming so. If I'm wrong, re-open.

For the record, I've been gathering fixes for cross-compiling the image.

@samueldr samueldr closed this Feb 3, 2020
@danbst
Copy link
Contributor

danbst commented Feb 4, 2020

@samueldr well at least raspberrypi-wireless was an issue I faced, so a fix for that would be awesome.

@samueldr
Copy link
Member

samueldr commented Feb 4, 2020

I know for a fact that this PR is old content from @ElvishJerricco. Maybe he could open a PR with the change? Or alternatively you could, @danbst?

I would, but prefer not doing a PR I have not tested personally. Though here the change looks self-contained and safe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samueldr samueldr Awaiting requested review from samueldr samueldr will be requested when the pull request is marked ready for review samueldr is a code owner

@dasJ dasJ Awaiting requested review from dasJ dasJ will be requested when the pull request is marked ready for review dasJ is a code owner

Assignees
No one assigned
Labels
2.status: merge conflict 6.topic: nixos 8.has: module (update)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MarcFontaine @danbst @samueldr @ElvishJerricco