Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rosegarden: add alsaLib as a dependency #78026

Merged
merged 1 commit into from Jan 19, 2020
Merged

rosegarden: add alsaLib as a dependency #78026

merged 1 commit into from Jan 19, 2020

Conversation

mawis
Copy link
Contributor

@mawis mawis commented Jan 19, 2020 •
edited

Without ALSA rosegarden will be built without MIDI support.

Fixes #77988

Motivation for this change

Fixing that Rosegarden did not support MIDI, which is probably one of the most important features of Rosegarden.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mawis
rosegarden: add alsaLib as a dependency
ebb3fa0 
Without ALSA rosegarden will be built without MIDI support.

Fixes NixOS#77988
@mawis
Copy link
Contributor Author

mawis commented Jan 19, 2020

cc @lebastr

@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build rosegarden

1 similar comment
@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build rosegarden

@worldofpeace worldofpeace merged commit 252e3a4 into NixOS:master Jan 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No audio driver/MIDI devices present in Rosegarden
3 participants
@mawis @worldofpeace @Janik-Haag