Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove myself from maintainers on some packages #78027

Merged
merged 1 commit into from Jan 19, 2020
Merged

Remove myself from maintainers on some packages #78027

merged 1 commit into from Jan 19, 2020

Conversation

ivan
Copy link
Member

@ivan ivan commented Jan 19, 2020

Motivation for this change

Removing myself from chromium, mpv, qolibri, and scream-receivers because I am not using much desktop Linux right now.

Removing myself from quickjs because I do not use it right now.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@veprbl veprbl merged commit 76ab115 into NixOS:master Jan 19, 2020
@veprbl
Copy link
Member

veprbl commented Jan 19, 2020

@ivan Thank you for your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ivan @veprbl