Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glirc: 2.33.1 -> 2.34 #77984

Merged
merged 1 commit into from Jan 20, 2020
Merged

glirc: 2.33.1 -> 2.34 #77984

merged 1 commit into from Jan 20, 2020

Conversation

Kiwi
Copy link
Member

@Kiwi Kiwi commented Jan 18, 2020

Motivation for this change

glirc update needed fixed. which needed a fix for regex-tdfa_1_3_1_0

Things done

fixed glirc build and that regex-tdfa version

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Kiwi
glirc: 2.33.1 -> 2.34
4d49c82 
Really this is a fix of the build because of the automatic version bump
@cdepillabout cdepillabout merged commit f6f961e into NixOS:haskell-updates Jan 20, 2020
@cdepillabout
Copy link
Member

@Kiwi Looks good. Thanks for keeping this updated?

Have you tried to get upstream to add this to stackage? If they did, it might be a little easier for you to keep it updated. (Most of the time you won't have to do anything)

@Kiwi Kiwi deleted the glirc-update branch February 11, 2020 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvandijk basvandijk Awaiting requested review from basvandijk

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Kiwi @cdepillabout