Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

distrho: 2018-04-16 -> unstable-2019-10-09 #77966

Merged
merged 1 commit into from
Jan 19, 2020
Merged

distrho: 2018-04-16 -> unstable-2019-10-09 #77966

merged 1 commit into from
Jan 19, 2020
+3 −3

Conversation

magnetophon
Copy link
Member

@magnetophon magnetophon commented Jan 18, 2020 •
edited
Loading

Motivation for this change

Fix build with gcc9

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ofborg ofborg bot requested a review from cillianderoiste January 18, 2020 07:03
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 18, 2020
@magnetophon
distrho: 2018-04-16 -> unstable-2019-10-09

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
b7be10e
@magnetophon magnetophon changed the title distrho: 2018-04-16 -> 2019-10-09 distrho: 2018-04-16 -> unstable-2019-10-09 Jan 19, 2020
marsam added a commit that referenced this pull request Jan 19, 2020
@marsam
Merge pull request #77966 from magnetophon/distrho

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
536fb1e 
distrho: 2018-04-16 -> unstable-2019-10-09
@marsam marsam merged commit 536fb1e into NixOS:master Jan 19, 2020
@marsam marsam merged commit b7be10e into NixOS:master Jan 19, 2020
@marsam
Copy link
Contributor

marsam commented Jan 19, 2020

Thanks!

@magnetophon magnetophon deleted the distrho branch January 19, 2020 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam

@cillianderoiste cillianderoiste

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@magnetophon @marsam