Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.bravia_tv: init at 1.0.1 #78014

Merged
merged 2 commits into from Mar 28, 2020
Merged

pythonPackages.bravia_tv: init at 1.0.1 #78014

merged 2 commits into from Mar 28, 2020

Conversation

colemickens
Copy link
Member

@colemickens colemickens commented Jan 19, 2020 •
edited

Motivation for this change

This introduces pythonPackages.bravia_tv.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@colemickens colemickens mentioned this pull request Jan 19, 2020
Closed
10 tasks
@colemickens colemickens force-pushed the nixpkgs-ha-pkgs-bravia branch 2 times, most recently from 2feb500 to ff674f2 Compare January 28, 2020 10:49
@colemickens colemickens changed the title pythonPackages.braviarc-homeassistant: init at 0.3.7.dev0 pythonPackages.braviarc: init at 0.3.8 Jan 28, 2020
@colemickens colemickens marked this pull request as ready for review January 28, 2020 10:51
@colemickens
Copy link
Member Author

This is now ready for review. Please note this is a recent fork of the braviarc lib. I've linked a Home Assistant issue in the initial PR text that explains why this is being done.

@colemickens colemickens changed the title pythonPackages.braviarc: init at 0.3.8 DO NOT MERGE: pythonPackages.braviarc: init at 0.3.8 Jan 30, 2020
@colemickens
Copy link
Member Author

More packaging changes incoming, do not merge for now.

@jonringer
Copy link
Contributor

when you create the PR, you should be able to select "create as draft"

@colemickens
Copy link
Member Author

colemickens commented Jan 31, 2020 •
edited

@jonringer Yes, I'm sorry, I've done that with some. Unfortunately it seems to be a one-time choice.

edit: I'm open to more feedback too. If it would be less noisy/annoying for me to close and then draft or re-open when ready, I can do that in the future too. Or if nixpkgs has a policy I'm unaware of.

@jonringer
Copy link
Contributor

@jonringer Yes, I'm sorry, I've done that with some. Unfortunately it seems to be a one-time choice.

I know :), wish they could allow it to be changed

@colemickens colemickens changed the title DO NOT MERGE: pythonPackages.braviarc: init at 0.3.8 pythonPackages.bravia_tv: init at 1.0.0 Feb 7, 2020
@ofborg ofborg bot requested review from globin and dotlambda February 7, 2020 13:46
@colemickens colemickens force-pushed the nixpkgs-ha-pkgs-bravia branch 2 times, most recently from a526e6e to 8d89bb2 Compare February 23, 2020 22:44
@colemickens colemickens changed the title pythonPackages.bravia_tv: init at 1.0.0 pythonPackages.bravia_tv: init at 1.0.1 Feb 23, 2020
@colemickens
Copy link
Member Author

This is tested, working e2e with Home-Assistant after running ./parse-requirements.py. I think it's ready for merge consideration. Would be nice to have it in for the next time HA gets updated so it will be included for the bravia plugin.

@Mic92
Copy link
Member

Mic92 commented Mar 28, 2020

You can also update home-assistant to include this module in its component description.

FRidh
FRidh requested changes Mar 28, 2020
View reviewed changes
pkgs/top-level/python-packages.nix Outdated Show resolved Hide resolved
@globin globin merged commit 9ce91ec into NixOS:master Mar 28, 2020
@colemickens colemickens deleted the nixpkgs-ha-pkgs-bravia branch December 30, 2022 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@FRidh FRidh FRidh requested changes

@jonringer jonringer Awaiting requested review from jonringer

@globin globin Awaiting requested review from globin

@dotlambda dotlambda Awaiting requested review from dotlambda

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@colemickens @jonringer @Mic92 @FRidh @globin