Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.flux_led: init at v0.22 #78013

Merged
merged 1 commit into from Jan 21, 2020
Merged

pythonPackages.flux_led: init at v0.22 #78013

merged 1 commit into from Jan 21, 2020

Conversation

colemickens
Copy link
Member

Motivation for this change

This is used by home-assistant when the fluxled/magichome led component is used.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@colemickens colemickens mentioned this pull request Jan 19, 2020
Closed
10 tasks
jonringer
jonringer reviewed Jan 19, 2020
View reviewed changes
pkgs/development/python-modules/flux-led/default.nix Show resolved Hide resolved
pkgs/development/python-modules/flux-led/default.nix Outdated
sha256 = "1zgajlkhclyrqhkmivna4ha2lyvfpk5929s042gy59p7mzpkvjx7";
};

doCheck = true;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default for buildPythonPackage

Suggested change
doCheck = true;

pkgs/development/python-modules/flux-led/default.nix Outdated
sha256 = "1zgajlkhclyrqhkmivna4ha2lyvfpk5929s042gy59p7mzpkvjx7";
};

doCheck = true;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default

Suggested change
doCheck = true;

@colemickens
Copy link
Member Author

Fixed up. Thanks!

jonringer
jonringer approved these changes Jan 21, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
commit LGTM
has tests 👍

[1 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/78013
2 package built:
python37Packages.flux-led python38Packages.flux-led

@jonringer
Copy link
Contributor

@GrahamcOfBorg build python37Packages.flux-led python38Packages.flux-led

@jonringer jonringer merged commit ad6e8aa into NixOS:master Jan 21, 2020
@colemickens colemickens deleted the nixpkgs-ha-pkgs-fluxled branch January 30, 2020 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@colemickens @jonringer