Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pypy: fix build on darwin #77991

Merged
merged 1 commit into from Jan 23, 2020
Merged

pypy: fix build on darwin #77991

merged 1 commit into from Jan 23, 2020

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Jan 18, 2020

Motivation for this change

Fixes #71275
cc @paulreimer

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@marsam marsam requested a review from FRidh as a code owner January 18, 2020 20:15
@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 6.topic: python labels Jan 18, 2020
@ofborg ofborg bot requested a review from andersk January 18, 2020 20:25
@marsam marsam merged commit 8a726f8 into NixOS:master Jan 23, 2020
@marsam marsam deleted the fix-pypy-darwin branch January 23, 2020 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@andersk andersk Awaiting requested review from andersk

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot Compile db (for pypy3) on macOS
1 participant
@marsam