Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

michabo: mark as broken as it's abandoned by upstream #77992

Closed
wants to merge 1 commit into from
Closed

michabo: mark as broken as it's abandoned by upstream #77992

wants to merge 1 commit into from

Conversation

schmittlauch
Copy link
Member

Motivation for this change

Michabo has been abandoned upstream as the maintainer is moving away from Fediverse development, see this thread.

@fgaz Any ideas on how to keep this updated in the future? Otherwise I suggest to mark it as broken and later remove it from nixpkgs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Contributor

worldofpeace commented Jan 19, 2020 •
edited

How long has it been being unmaintained that it would be "broken"?
Marking a package as broken isn't the same as warning that this software is abandoned, it my very will still build in nixpkgs up to a point. I know some devs even use the term "maintenance mode" when they're accepting contributions or looking for a new developer. It would be nice if we had a better way to discourage use of the package, but I don't think broken is for this.

@fgaz
Copy link
Member

fgaz commented Jan 21, 2020 •
edited

maintenance mode

This does not seem to be the case. Not sure if merge requests will be completely ignored or not, but as the dev put it:

probably should be forked

Still, I don't think we should remove michabo from nixpkgs or mark it as broken. It still works with no security problems, and actually it's the only native desktop fediverse client that doesn't crash (from my experience), and that's reason enough to keep it, IMO.

@schmittlauch
Copy link
Member Author

@fgaz If yo as a maintainer are going to keep an eye on it, I'm closing this until further issues arise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fgaz fgaz Awaiting requested review from fgaz

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@schmittlauch @worldofpeace @fgaz