Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nebula: 1.0.0 -> 1.1.0 #77976

Merged
merged 1 commit into from
Jan 18, 2020
Merged

nebula: 1.0.0 -> 1.1.0 #77976

merged 1 commit into from
Jan 18, 2020
+3 −3

Conversation

Br1ght0ne
Copy link
Member

@Br1ght0ne Br1ght0ne commented Jan 18, 2020 •
edited
Loading

Motivation for this change

https://github.com/slackhq/nebula/releases/tag/v1.1.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This change is Reviewable

Sorry, something went wrong.

@Br1ght0ne
nebula: 1.0.0 -> 1.1.0

Verified

This commit was signed with the committer’s verified signature. The key has expired.
andir Andreas Rammhold
GPG key ID: E432E410B5E48C86
Expired
Verified
Learn about vigilant mode
ae3ba80
@ofborg ofborg bot requested a review from kalbasit January 18, 2020 12:01
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jan 18, 2020
@marsam marsam merged commit e517c52 into NixOS:master Jan 18, 2020
@marsam
Copy link
Contributor

marsam commented Jan 18, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Br1ght0ne @marsam