Skip to content

amp: git rev 2c88e8 (2019-06-09) -> 0.6.1 #77975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 12, 2020
Merged

amp: git rev 2c88e8 (2019-06-09) -> 0.6.1 #77975

merged 1 commit into from
Feb 12, 2020
+4 −5

Conversation

sjmackenzie
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from sbourdeauducq January 18, 2020 12:01
sbourdeauducq
sbourdeauducq reviewed Jan 18, 2020
View reviewed changes
pkgs/applications/editors/amp/default.nix Outdated

src = fetchFromGitHub {
owner = "jmacdonald";
repo = pname;
rev = "2c88e82a88ada8a5fd2620ef225192395a4533a2";
sha256 = "0ha1xiabq31s687gkrnszf3zc7b3sfdl79iyg5ygbc49mzvarp8c";
rev = "e49c71d85a17a8d17423c1ab73758a0f84bcb89a";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rev = version?

Copy link
Contributor Author

@sjmackenzie sjmackenzie Jan 18, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, tested locally and it builds with rev = version. where version = "0.6.1";, change request pushed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe "0.6.1" and not "v0.6.1" is the right version string anyway; this is actually one of the rare semi-niche details of Nix that is well documented :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yeah, the code is "0.6.1" https://github.com/NixOS/nixpkgs/pull/77975/files#diff-4cffb3d20d020832568c2a4eafe65e64R6

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah you mean in the commit message - hmm I really wonder if that even matters. Is it worth kicking off all the CI resources just to drop a character in the commit message?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yo sebastien, can you please check the review thingy.

@sjmackenzie
amp: git rev 2c88e8 (2019-06-09) -> v0.6.1

Verified

This commit was signed with the committer’s verified signature.
jtojnar Jan Tojnar
GPG key ID: 7FAB2A15F7A607A4
Verified
Learn about vigilant mode
521ac53
@ofborg ofborg bot requested a review from sbourdeauducq January 18, 2020 13:04
@sjmackenzie sjmackenzie requested a review from joachifm January 18, 2020 17:54
@sjmackenzie sjmackenzie changed the title amp: git rev 2c88e8 (2019-06-09) -> v0.6.1 amp: git rev 2c88e8 (2019-06-09) -> 0.6.1 Jan 18, 2020
@joachifm joachifm removed their request for review January 20, 2020 15:47
@sjmackenzie
Copy link
Contributor Author

sjmackenzie commented Feb 11, 2020 •
edited
Loading

could someone be a dear and merge this please? cc @qknight @adisbladis

@adisbladis adisbladis merged commit 8a25300 into NixOS:master Feb 12, 2020
@sjmackenzie sjmackenzie deleted the amp branch March 16, 2020 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbourdeauducq sbourdeauducq

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sjmackenzie @sbourdeauducq @adisbladis