Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

matterhorn: init at 50200.6.0 #78029

Merged
merged 1 commit into from Jan 20, 2020
Merged

matterhorn: init at 50200.6.0 #78029

merged 1 commit into from Jan 20, 2020

Conversation

Kiwi
Copy link
Member

@Kiwi Kiwi commented Jan 19, 2020

Command line mattermost client

Motivation for this change

@evils-devils wanted this and it didn't work so I made it work

Things done

Made haskellPackages.matterhorn build and added it to top-level too

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Kiwi
Copy link
Member Author

Kiwi commented Jan 19, 2020

I did this to the wrong branch again didn't I

@Kiwi Kiwi changed the base branch from master to haskell-updates January 19, 2020 14:52
@Kiwi
matterhorn: init at 50200.6.0
592b8e5 
Command line mattermost client
@evils
Copy link
Member

evils commented Jan 19, 2020 •
edited

seems to work, thanks!
matterhorn wasn't available in nix-review
i had to unmark matterhorn and Unique as broken (mark as unbroken? broken = false; or just remove their broken = true;) in pkgs/development/haskell-modules/hackage-packages.nix to have it work via nix-build
presumably there's some automated system that'd do that at some point

@cdepillabout cdepillabout merged commit f161520 into NixOS:haskell-updates Jan 20, 2020
@cdepillabout
Copy link
Member

Looks good, thanks again.

@Kiwi Kiwi deleted the matterhorn branch February 11, 2020 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvandijk basvandijk Awaiting requested review from basvandijk

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Kiwi @evils @cdepillabout