I addressed the review comment.
Regarding refactoring, I tried to use perl.withPackages. The libguestfs perl commands depend on a perl module path in the derivation itself (second --prefix PERL5LIB argument to makeWrapper). But perl.withPackages produces a wrapped perl that simply sets PERL5LIB, overwriting the inherited PERL5LIB content without adding to it. I wasn't sure how to deal with that.

Hello, I'm a bot and I thank you in the name of the community for your contributions.

Nixpkgs is a busy repository, and unfortunately sometimes PRs get left behind for too long. Nevertheless, we'd like to help committers reach the PRs that are still important. This PR has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human.

If this is still important to you and you'd like to remove the stale label, we ask that you leave a comment. Your comment can be as simple as "still important to me". But there's a bit more you can do:

If you received an approval by an unprivileged maintainer and you are just waiting for a merge, you can @ mention someone with merge permissions and ask them to help. You might be able to find someone relevant by using Git blame on the relevant files, or via GitHub's web interface. You can see if someone's a member of the nixpkgs-committers team, by hovering with the mouse over their username on the web interface, or by searching them directly on the list.

If your PR wasn't reviewed at all, it might help to find someone who's perhaps a user of the package or module you are changing, or alternatively, ask once more for a review by the maintainer of the package/module this is about. If you don't know any, you can use Git blame on the relevant files, or GitHub's web interface to find someone who touched the relevant files in the past.

If your PR has had reviews and nevertheless got stale, make sure you've responded to all of the reviewer's requests / questions. Usually when PR authors show responsibility and dedication, reviewers (privileged or not) show dedication as well. If you've pushed a change, it's possible the reviewer wasn't notified about your push via email, so you can always officially request them for a review, or just @ mention them and say you've addressed their comments.

Lastly, you can always ask for help at our Discourse Forum, or more specifically, at this thread or at #nixos' IRC channel.

I marked this as stale due to inactivity. → More info

Seems virt-list-partitions or virt-list-filesystems have been replaced: https://libguestfs.org/virt-filesystems.1.html
Is this PR still needed?

In case we still need it, I merged master into it, to fix the conflicts.

I've opened a version update for libguestfs which addresses the issue with the Perl bindings: #185015. Note that as of libguestfs 1.46, many of the CLI tools (including virt-filesystems) have moved to the new guestfs-tools project. That one is not yet packaged for NixOS, but I'm giving it a stab right now (#185029).