Alternative: move commit checker from Azure Pipelines to Github Actions #7948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TrueBrain
changed the title
|
Closing in favour of #7943 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Meant as alternative to #7943
Example result: https://github.com/TrueBrain/OpenTTD/pull/10/checks
Main drawback of this approach is that when a commits are pushed while the Action is starting, that Action can pick up a newer version that it is supposed to. I would estimate that as rare, and if it happens there also isn't a real issue. But it is a bit sad we have to use the reference, and we cannot use the hash or something :)