Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

corerad: 0.1.8 -> 0.1.9 #78034

Merged
merged 2 commits into from Jan 22, 2020
Merged

corerad: 0.1.8 -> 0.1.9 #78034

merged 2 commits into from Jan 22, 2020

Conversation

mdlayher
Copy link
Member

@mdlayher mdlayher commented Jan 19, 2020 •
edited

Motivation for this change

CoreRAD v0.1.9 introduces a small change to the config format that also necessitates a minor change to the NixOS module test. I wasn't sure if it was preferred to do the dependent change in the same PR, or in a different one. Let me know either way.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Both changes have been verified:

$ nix-build nixos/tests/corerad.nix
[...]
client: connected to guest root shell
client: (connecting took 0.00 seconds)
(0.17 seconds)
client: waiting for success: ping -c 1 fd00:dead:beef:dead::1
router # [   75.078734] corerad[741]: 2020/01/19 16:25:34 CoreRAD v0.1.9 (ALPHA) starting with configuration file "/nix/store/axjwfhk5iw9mk1dvrg87plivhb4kgrcd-corerad.toml"
router # [   75.167848] corerad[741]: 2020/01/19 16:25:34 eth1: "prefix": ::/64 [on-link, autonomous], preferred: 4h0m0s, valid: 24h0m0s
router # [   75.205786] corerad[741]: 2020/01/19 16:25:34 eth1: "lla": source link-layer address: 52:54:00:12:01:02
router # [   75.234719] corerad[741]: 2020/01/19 16:25:34 eth1: initialized, advertising from fe80::5054:ff:fe12:102
(11.57 seconds)
(91.23 seconds)
Verify SLAAC on client
client: waiting for success: rdisc6 -1 -r 10 eth1
(0.20 seconds)
client: waiting for success: ip -6 addr show dev eth1 | grep -q 'fd00:dead:beef:dead:'
(0.17 seconds)
client: must succeed: ip -6 addr show dev eth1
(0.04 seconds)
(0.41 seconds)
(92.72 seconds)
2 out of 2 tests succeeded
test script finished in 92.92s
cleaning up
killing client (pid 9)
killing router (pid 21)
(0.01 seconds)
/nix/store/raicncj37n0h2w28s4rpdng4if44bfgd-vm-test-run-unnamed

/cc @danderson

@mdlayher
Copy link
Member Author

@GrahamcOfBorg test corerad

@ofborg ofborg bot requested a review from kalbasit January 19, 2020 16:47
jonringer
jonringer approved these changes Jan 22, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

[4 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/78034
1 package built:
corerad

@jonringer jonringer merged commit 50c661c into NixOS:master Jan 22, 2020
@mdlayher
Copy link
Member Author

Thank you!

@mdlayher mdlayher deleted the mdl-corerad-0.1.9 branch February 7, 2020 03:00
@mdlayher mdlayher mentioned this pull request Feb 7, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mdlayher @jonringer