Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

captive-browser: runs on all platforms #78019

Merged
merged 1 commit into from Jan 19, 2020
Merged

captive-browser: runs on all platforms #78019

merged 1 commit into from Jan 19, 2020

Conversation

zaninime
Copy link
Contributor

Motivation for this change

captive-browser doesn't depend on a specific OS. It's configurable through a file where you can specify OS-specific dependencies (examples provided in upstream repo). I'm successfully using it on MacOS.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from volth and ehmry January 19, 2020 09:42
@flokli flokli merged commit d1a6016 into NixOS:master Jan 19, 2020
@zaninime zaninime deleted the patch-1 branch July 30, 2022 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehmry ehmry Awaiting requested review from ehmry

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zaninime @flokli