Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19.09] [backport] chromium: 79.0.3945.88 -> 79.0.3945.117 #78022

Closed
wants to merge 1 commit into from
Closed

[19.09] [backport] chromium: 79.0.3945.88 -> 79.0.3945.117 #78022

wants to merge 1 commit into from

Conversation

mebubo
Copy link
Contributor

@mebubo mebubo commented Jan 19, 2020

Backport #77299 (not yet merged to master) to 19.09.

https://chromereleases.googleblog.com/2020/01/stable-channel-update-for-desktop.html

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@flokli
Copy link
Contributor

flokli commented Jan 19, 2020

Let's await #77299 having landed.

@primeos primeos mentioned this pull request Jan 27, 2020
Merged
10 tasks
@primeos
Copy link
Member

primeos commented Jan 27, 2020 •
edited

Update: #77299 is merged and already in nixos-unstable by now.

@flokli should we merge this PR first or directly test #78603? And do you know if we have a "standardized" (working) procedure for Chromium backports (e.g. are backports usually fine when they're fine on master or do we have to re-run all/some tests)?

@mebubo just a quick FYI: Please cherry-pick with the -x option, if possible, to reference the commit from master.

Update: The AArch64 build is failing due to the patches but this is already the case without this PR (i.e. no new regression): https://hydra.nixos.org/build/110325603 - I've included the existing fix in #78603.

@primeos
Copy link
Member

primeos commented Jan 28, 2020

Closing this PR as I've just merged #78584 and we should therefore focus on #78603 now.

@primeos primeos closed this Jan 28, 2020
@mebubo
Copy link
Contributor Author

mebubo commented Jan 29, 2020

@mebubo just a quick FYI: Please cherry-pick with the -x option, if possible, to reference the commit from master.

Thanks for the hint @primeos, I'll be using it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mebubo @flokli @primeos @ivan