Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hplip: fix hplipWithPlugin #78023

Closed
wants to merge 1 commit into from
Closed

hplip: fix hplipWithPlugin #78023

wants to merge 1 commit into from

Conversation

Kiwi
Copy link
Member

@Kiwi Kiwi commented Jan 19, 2020

The recent version bump to 3.19.12 does not have a corresponding plugin version
This fixes it so hplipWithPlugin will install 3.19.6 instead

Motivation for this change

The update a few days ago broke hplipWithPlugin because the most recent version of the plugin does not match the most recent version of the driver.

Things done

made it use the last version if withPlugin is true

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Kiwi Kiwi requested a review from Mic92 January 19, 2020 12:41
@ofborg ofborg bot requested a review from ttuegel January 19, 2020 12:50
@flokli
Copy link
Contributor

flokli commented Jan 19, 2020 •
edited

@Kiwi thanks, verified this works for me.

Can you report a bug at https://bugs.launchpad.net/hplip (which seems to be their somewhat official bug tracker), and add a link to that as a comment?

@Kiwi
Copy link
Member Author

Kiwi commented Jan 20, 2020

@Kiwi thanks, verified this works for me.

Can you report a bug at https://bugs.launchpad.net/hplip (which seems to be their somewhat official bug tracker), and add a link to that as a comment?

The likelihood of me signing up for launchpad is... low. I found several previous issues though so it's a common problem and they seem to know about it (and not care) anyway... the most recent 4-5 versions don't have plugins either.

I'd be happy to add a comment with a link to this
https://bugs.launchpad.net/hplip/+bug/1644932

@flokli
Copy link
Contributor

flokli commented Jan 20, 2020

I added a comment at the linked launchpad bug.

Can you add a comment linking to it inside the derivation, explaining this breaks quite often?

@Kiwi
hplip: fix hplipWithPlugin
002b38a 
The recent version bump to 3.19.12 does not have a corresponding plugin version
This fixes it so hplipWithPlugin will install 3.19.6 instead
@Kiwi
Copy link
Member Author

Kiwi commented Jan 21, 2020

it has been done

@flokli flokli mentioned this pull request Jan 22, 2020
Merged
10 tasks
@flokli
Copy link
Contributor

flokli commented Jan 22, 2020 •
edited

superseded by #78257.

@flokli flokli closed this Jan 22, 2020
@Kiwi Kiwi deleted the hplip-fix branch January 22, 2020 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Awaiting requested review from Mic92

@ttuegel ttuegel Awaiting requested review from ttuegel

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Kiwi @flokli