Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge pull request #78025 from wamserma/minidlna-interval-backport #78025

Merged
merged 1 commit into from
Jan 27, 2020
Merged

Merge pull request #78025 from wamserma/minidlna-interval-backport #78025

merged 1 commit into from
Jan 27, 2020
+17 −0

Conversation

wamserma
Copy link
Member

@wamserma wamserma commented Jan 19, 2020 •
edited
Loading

Motivation for this change

backport of #78024

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@wamserma
minidlna: provide configuration option for announce interval
587b451 
Signed-off-by: Markus S. Wamser <github-dev@mail2013.wamser.eu>
@wamserma wamserma requested a review from obadz January 19, 2020 13:42
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 19, 2020
@wamserma wamserma changed the title Minidlna interval backport minidlna: provide configuration option for announce interval (backport) Jan 19, 2020
@wamserma wamserma force-pushed the minidlna-interval-backport branch from 3278eb5 to 587b451 Compare January 19, 2020 19:32
jonringer
jonringer approved these changes Jan 22, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @infinisil

@jonringer jonringer requested a review from infinisil January 22, 2020 09:20
@jonringer
Copy link
Contributor

@GrahamcOfBorg test minidlna

@infinisil infinisil changed the title minidlna: provide configuration option for announce interval (backport) Merge pull request #78025 from wamserma/minidlna-interval-backport Jan 27, 2020
@infinisil infinisil merged commit 274e095 into NixOS:release-19.09 Jan 27, 2020
@wamserma wamserma mentioned this pull request Jan 28, 2020
Merged
10 tasks
@wamserma wamserma deleted the minidlna-interval-backport branch April 18, 2020 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer

@infinisil infinisil

@obadz obadz

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wamserma @jonringer @infinisil