Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minidlna: provide configuration option for announce interval #78024

Merged
merged 1 commit into from Feb 10, 2020
Merged

minidlna: provide configuration option for announce interval #78024

merged 1 commit into from Feb 10, 2020

Conversation

wamserma
Copy link
Member

Signed-off-by: Markus S. Wamser github-dev@mail2013.wamser.eu

Motivation for this change

Provide a configuration option to set announce interval in miniDLNA config file.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@wamserma
minidlna: provide configuration option for announce interval
d4718f1 
Signed-off-by: Markus S. Wamser <github-dev@mail2013.wamser.eu>
@wamserma wamserma mentioned this pull request Jan 19, 2020
Merged
10 tasks
@wamserma wamserma requested a review from obadz January 20, 2020 20:53
@obadz
Copy link
Contributor

obadz commented Jan 28, 2020

Does that help with VLC as a client? I ended up giving up on DLNA and switching to FTP because VLC couldn't find MiniDLNA.

@wamserma
Copy link
Member Author

wamserma commented Jan 28, 2020 •
edited

@obadz It did help me with Skifta to see the Server soon after firing up the app. I guess a shorter announce-interval also helps with other Clients.
I kindly ask for merging this soon, as has already been done for the backport (#78025).

edit: Just tested with VLC on Ubuntu 18.04 as client and miniDLNA on NixOS stable as server, announce interval set to 60 seconds. The server was quickly detected after clicking the Universal Plug'n'Pray entry in the playlist window.

Remeber you have to explicitly open TCP port 8200 for miniDLNA.

@wamserma
Copy link
Member Author

wamserma commented Feb 7, 2020

cc @infinisil backport of this (#78025) has already been merged

@infinisil infinisil merged commit 6169eef into NixOS:master Feb 10, 2020
@infinisil
Copy link
Member

Ah sorry for the delay. It might be a good idea to only open backport PRs if the main one is merged so this doesn't happen (also keeps the discussion in one place).

@wamserma wamserma deleted the minidlna-interval branch February 10, 2020 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obadz obadz Awaiting requested review from obadz

@infinisil infinisil Awaiting requested review from infinisil

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wamserma @obadz @infinisil