Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: GlasgowEmbedded/glasgow
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 939ddec21575
Choose a base ref
...
head repository: GlasgowEmbedded/glasgow
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: b022b2ca21a8
Choose a head ref
  • 2 commits
  • 1 file changed
  • 1 contributor

Commits on Jan 19, 2020

  1. applet.audio.yamaha_opx: relax timeout. 

    The current value is way too aggressive and leads to spurious
timeouts in some conditions. The only purpose of this timeout is
to guard against a hung undervolted chip, so the exact value is
not very important, only that it's not too long.
    @whitequark
    whitequark committed Jan 19, 2020

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    3eaaf4f View commit details

  2. applet.audio.yamaha_opx: fix outdated help text.

    @whitequark
    whitequark committed Jan 19, 2020
    Copy the full SHA
    b022b2c View commit details
Showing with 2 additions and 2 deletions.
  1. +2 −2 software/glasgow/applet/audio/yamaha_opx/__init__.py
4 changes: 2 additions & 2 deletions software/glasgow/applet/audio/yamaha_opx/__init__.py
View file
Original file line number Diff line number Diff line change
@@ -904,7 +904,7 @@ async def serve_vgm(self, request):
if play_fut.done() and play_fut.exception():
break

samples = await asyncio.wait_for(sample_queue.get(), timeout=1.0)
samples = await asyncio.wait_for(sample_queue.get(), timeout=5.0)
if not samples:
break
await sock.send_bytes(samples)
@@ -978,7 +978,7 @@ class AudioYamahaOPxApplet(GlasgowApplet, name="audio-yamaha-opx"):
The written samples can be played with the knowledge of the sample rate, which is derived from
the master clock frequency specified in the input file. E.g. using SoX:
$ play -r 49715 output.u16
$ play -r 49715 output.s16
# Scripting