llvm: remove 3.5, 3.8 and 4 #77989
Merged
llvm: remove 3.5, 3.8 and 4 #77989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lblasc
requested review from
basvandijk,
cdepillabout,
infinisil and
matthewbauer
as code owners
ofborg
bot
requested review from
puffnfresh,
amiloradovsky,
7c6f434c,
thoughtpolice,
asppsa and
jchv
jchv
approved these changes
Jan 18, 2020
peti
requested changes
Jan 19, 2020
|
Is there anything else that prevents us from merging? |
| @@ -40,5 +40,6 @@ stdenv.mkDerivation rec { | |||
| platforms = with lib.platforms; | |||
| linux; | |||
| license = lib.licenses.gpl3Plus; | |||
| broken = true; | |||
There was a problem hiding this comment.
please comment why it's broken.
There was a problem hiding this comment.
Pure requires LLVM 3.5 because it's based on the old JIT API that was removed in subsequent versions.
asppsa
approved these changes
Jan 28, 2020
|
I certainly see your point :) |
Aarch64 binary is not used.
With this change, expressions relying on those old LLVM versions will fail with a meaningful error message.
worldofpeace
force-pushed
the
llvm3-removal
branch
from
97b1e79
to
f73d725
Compare
|
Rebased because of release note conflict, and I moved the re-added attrs to aliases.nix f73d725. |
dtzWill
pushed a commit
to dtzWill/nixpkgs
that referenced
this pull request
Feb 2, 2020
llvm: remove 3.5, 3.8 and 4 (cherry picked from commit 645ea32)
dtzWill
added a commit
to dtzWill/nixpkgs
that referenced
this pull request
Feb 2, 2020
This reverts commit 28a9324.
dtzWill
added a commit
to dtzWill/nixpkgs
that referenced
this pull request
Feb 2, 2020
…val"" This reverts commit df50d12.
anna328p
pushed a commit
to anna328p/nixpkgs
that referenced
this pull request
Feb 2, 2020
llvm: remove 3.5, 3.8 and 4
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
In #66528 we're working on an update of glibc to version 2.30.
LLVM versions 3.5, 3.8 and 4 are very much outdated, they don't build any more. There is similar pull request #77985 for removal of old gcc versions, problematic part is
<sys/ustat.h>header which was removed in 2.28.All packages which depended on old llvm version are updated and only pure package is now marked broken.
I'm new to Haskell expressions, hope those changes are fine. cc @peti
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)