Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aria2p: init at 0.7.0 #77981

Merged
merged 1 commit into from Jan 24, 2020
Merged

aria2p: init at 0.7.0 #77981

merged 1 commit into from Jan 24, 2020

Conversation

k0ral
Copy link
Contributor

@k0ral k0ral commented Jan 18, 2020

Motivation for this change

Install aria2p tool.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@k0ral k0ral changed the base branch from master to nixos-unstable January 19, 2020 13:33
@k0ral k0ral force-pushed the aria2p branch 2 times, most recently from dd66e66 to 4973bc0 Compare January 24, 2020 08:25
@jonringer jonringer changed the base branch from nixos-unstable to master January 24, 2020 10:15
@jonringer
Copy link
Contributor

the nixos-* branches are for release channels. You want to target master for new additions

jonringer
jonringer reviewed Jan 24, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, forgot a few things, otherwise LGTM

pkgs/development/python-modules/aria2p/default.nix

buildPythonPackage rec {
pname = "aria2p";
version = "0.7.0";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's a special builder for poetry

Suggested change
version = "0.7.0";
version = "0.7.0";
format = "pyproject";

Copy link
Contributor Author

@k0ral k0ral Jan 24, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. This could use some documentation :) .
Also, considering that this builder is specific to poetry, I am surprised I still have to explicitly mention the poetry dependency (I tried removing it and it broke.)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The poetry as a top-level package happened recently, but agreed, it should be updated. The only reason why i know it exists is because I read through the source.

pkgs/development/python-modules/aria2p/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/aria2p/default.nix Outdated Show resolved Hide resolved
jonringer
jonringer approved these changes Jan 24, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM

failure is due not supporting poetry case in python3.8 yet

[2 built (1 failed), 48 copied (30.8 MiB), 7.9 MiB DL]
error: build of '/nix/store/mlikqdv3rl99vmbwa1ymc8fdyrvnxvi3-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/77981
1 package failed to build:
python38Packages.aria2p

1 package built:
python37Packages.aria2p

@jonringer
Copy link
Contributor

@GrahamcOfBorg build python37Packages.aria2p

@jonringer jonringer merged commit 40a03a8 into NixOS:master Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@k0ral @jonringer