Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

podman: enable on darwin #78002

Merged
merged 2 commits into from Jan 22, 2020
Merged

podman: enable on darwin #78002

merged 2 commits into from Jan 22, 2020

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Jan 19, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 8.has: package (new) labels Jan 19, 2020
saschagrunert
saschagrunert reviewed Jan 19, 2020
View reviewed changes
pkgs/applications/virtualization/podman/disable-go-module-mode.patch Outdated
varlink

GO_BUILD=$(GO) build
-# Go module support: set `-mod=vendor` to use the vendored sources
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The -mod=vendor should ensure that we do always use the vendored dependencies. So I’m wondering if we really need this patch at all.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting, I assumed that GO111MODULE=on made network requests for the checksum database, but it does not seem the case here.
I've removed the patch, thanks!

@ofborg ofborg bot requested a review from saschagrunert January 22, 2020 03:42
saschagrunert
saschagrunert approved these changes Jan 22, 2020
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vdemeester
vdemeester approved these changes Jan 22, 2020
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

@marsam marsam merged commit 2316b8d into NixOS:master Jan 22, 2020
@marsam marsam deleted the update-podman branch January 22, 2020 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@saschagrunert saschagrunert saschagrunert approved these changes

@ehmry ehmry Awaiting requested review from ehmry

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marsam @vdemeester @saschagrunert