Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/multitouch: remove (properly known as mtrack) #78004

Merged
merged 2 commits into from Jan 20, 2020

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

On numerous occasions I have seen users mistake this
module as libinput because it being called "multitouch"
and them being unaware that the actually module they want
is libinput. They then run into several decrepit bugs due
to the completely out-of-date nature of the underlying package.
The underlying package hasn't been changed to an up-to-date
fork in a period of 8 years. I don't consider this to be production quality.
However, I'm not opposed for the module being readded to NixOS
with new packaging, and a better name.

On a realer note

Literally the woes of people on social sites, irc, pms, and twitter 馃ぃ.
Somehow this is a common confusion.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@evanjs
Copy link
Member

evanjs commented Jan 19, 2020

This was particularly nasty because it was not marked as "conflicting" with libinput, and would install fine, but prevent touchpad from working on specific setups.
With both libinput and multitouch enabled on my laptop, for example, I was able to use gpm, and xmonad if launched with lightdm, but not xmonad launched with gdm.

Thanks for cleaning this up!

On numerous occasions I have seen users mistake this
module as libinput because it being called "multitouch"
and them being unaware that the actually module they want
is libinput. They then run into several decrepit bugs due
to the completely out-of-date nature of the underlying package.
The underlying package hasn't been changed to an up-to-date
fork in a period of 8 years. I don't consider this to be production quality.
However, I'm not opposed for the module being readded to NixOS
with new packaging, and a better name.
The source repo doesn't exist and it hasn't been touched in 8 years.
There is also no module to interface with it in NixOS.
@worldofpeace worldofpeace merged commit 348e48f into NixOS:master Jan 20, 2020
@worldofpeace worldofpeace deleted the mtrack-remove branch January 20, 2020 22:08
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/january-2020-in-nixos/5771/1

@NixOS NixOS deleted a comment from nixos-discourse Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants