Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: GlasgowEmbedded/glasgow
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: d96c235fc8c5
Choose a base ref
...
head repository: GlasgowEmbedded/glasgow
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 03019f148ab5
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Jan 19, 2020

  1. applet.internal.selftest: fix pins-loop. 

    Changes in bea50eb & 5506af7 broke pins-loop.
    @miek @whitequark
    miek authored and whitequark committed Jan 19, 2020
    Copy the full SHA
    03019f1 View commit details
Showing with 2 additions and 2 deletions.
  1. +2 −2 software/glasgow/applet/internal/selftest/__init__.py
4 changes: 2 additions & 2 deletions software/glasgow/applet/internal/selftest/__init__.py
View file
Original file line number Diff line number Diff line change
@@ -180,8 +180,8 @@ def decode_pins(bits):
broken = []
for bit in range(0, 8):
for o in (1 << bit, 1 << (15 - bit)):
await reset_pins()
i, desc = await check_pins(o, o)
await reset_pins(bits=0x0000)
i, desc = await check_pins(o, o, use_pull=False)
self.logger.debug("%s: %s", mode, desc)

e = (1 << bit) | (1 << (15 - bit))