Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ferm: 2.5.0 -> 2.5.1 #85164

Merged
merged 1 commit into from Apr 21, 2020
Merged

ferm: 2.5.0 -> 2.5.1 #85164

merged 1 commit into from Apr 21, 2020

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Apr 13, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member Author

Mic92 commented Apr 13, 2020

@GrahamcOfBorg test ferm

jonringer
jonringer approved these changes Apr 13, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

https://github.com/NixOS/nixpkgs/pull/85164
1 package built:
ferm

@Mic92
Copy link
Member Author

Mic92 commented Apr 13, 2020

@GrahamcOfBorg test ferm

@Mic92 Mic92 changed the title ferm: 2.4.1 -> 2.5.1 ferm: 2.5.0 -> 2.5.1 Apr 20, 2020
@Mic92
Copy link
Member Author

Mic92 commented Apr 20, 2020

Updated and cleaned up the build: @GrahamcOfBorg test ferm

@FRidh FRidh merged commit b1e93dd into NixOS:master Apr 21, 2020
@Mic92 Mic92 deleted the ferm branch April 21, 2020 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mic92 @jonringer @FRidh