Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go packages: remove darwin security #85122

Merged
merged 4 commits into from Apr 13, 2020
Merged

go packages: remove darwin security #85122

merged 4 commits into from Apr 13, 2020

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Apr 13, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @LnL7 @marsam @Mic92

@zowoq
Revert "gotools: fix darwin build"
b3ef62b 
This reverts commit cb75c0f.

Not needed now that Security is propagated via go 0bba747
@zowoq
Revert "amass: enable on darwin"
8660728 
This reverts commit 692b890.

Not needed now that Security is propagated via go 0bba747
@zowoq
gitAndTools.hub: remove Security
56480fe 
Not needed now that Security is propagated via go 0bba747
@zowoq
wal-g: remove Security
c217a1a 
Not needed now that Security is propagated via go 0bba747
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Apr 13, 2020
@Mic92 Mic92 merged commit fd0055b into NixOS:master Apr 13, 2020
@zowoq zowoq deleted the go-security branch April 13, 2020 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@globin globin Awaiting requested review from globin

@the-kenny the-kenny Awaiting requested review from the-kenny

@kalbasit kalbasit Awaiting requested review from kalbasit

@ocharles ocharles Awaiting requested review from ocharles

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zowoq @Mic92