Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exa: include patch to group dir symlinks with regular dirs #85064

Closed
wants to merge 1 commit into from
Closed

exa: include patch to group dir symlinks with regular dirs #85064

wants to merge 1 commit into from

Conversation

kraem
Copy link
Member

@kraem kraem commented Apr 12, 2020

Motivation for this change

exa patched to group symlinks to dirs with regular dirs when passing --group-directories-first

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kraem kraem changed the title exa: include patch to group dir symlinks with dirs exa: include patch to group dir symlinks with regular dirs Apr 12, 2020
@ofborg ofborg bot requested review from lilyball, globin and ehegnes April 12, 2020 10:16
@lilyball
Copy link
Member

What's the reasoning for pulling in a single patch like this? It doesn't look like a critical bug fix, and the ticket the patch is for is marked as a feature request.

@kraem
Copy link
Member Author

kraem commented Jun 18, 2020

I've seen other packages in nixpkgs which includes patches that were merged upstream but a new version haven't been released yet with the patch included, so it's not available in nixpkgs yet. If that doesn't hold I'll close this PR, np 👍

@lilyball
Copy link
Member

That's generally done because the patch is important for its packaging in nixpkgs (e.g. it fixes an issue that affected its ability to be packaged by nixpkgs) or it's a security issue.

@kraem kraem closed this Jun 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilyball lilyball Awaiting requested review from lilyball

@globin globin Awaiting requested review from globin

@ehegnes ehegnes Awaiting requested review from ehegnes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kraem @lilyball