Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
Update 1password to version 0.9.4.
The Darwin version comes as a
.pkg
file instead of a zip as previously, I wasn't quite sure how to deal with this, so i used this as a reference. Seems to work well asfile
recognizes it as anMach-O 64-bit x86_64 executable
. I unfortunately do not have a Mac or i686-linux machine to test, but the x86_64-linux version works perfectly. Also switched toautoPatchelfHook
for the Linux version. Apologies if something is not right, I'm quite a beginner at this.Would really appreciate it if someone with a Darwin machine could test.
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)