Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1password: 0.7.0 -> 0.9.4 #85077

Merged
merged 1 commit into from Apr 12, 2020
Merged

1password: 0.7.0 -> 0.9.4 #85077

merged 1 commit into from Apr 12, 2020

Conversation

IvarWithoutBones
Copy link
Member

@IvarWithoutBones IvarWithoutBones commented Apr 12, 2020

Things done

Update 1password to version 0.9.4.
The Darwin version comes as a .pkg file instead of a zip as previously, I wasn't quite sure how to deal with this, so i used this as a reference. Seems to work well as file recognizes it as an Mach-O 64-bit x86_64 executable. I unfortunately do not have a Mac or i686-linux machine to test, but the x86_64-linux version works perfectly. Also switched to autoPatchelfHook for the Linux version. Apologies if something is not right, I'm quite a beginner at this.

Would really appreciate it if someone with a Darwin machine could test.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bhipple
Copy link
Contributor

bhipple commented Apr 12, 2020

Result of nixpkgs-review pr 85077 1

1 package built:
- _1password

@bhipple bhipple merged commit d4dea95 into NixOS:master Apr 12, 2020
@IvarWithoutBones IvarWithoutBones deleted the 1password branch April 12, 2020 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants