Skip to content

nixos/displayManager: make autoLogin options independent of DM type #85065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 10, 2020
Merged

nixos/displayManager: make autoLogin options independent of DM type #85065

merged 1 commit into from
Jul 10, 2020

Conversation

worldofpeace
Copy link
Contributor

Co-authored-by: volth volth@volth.com

Motivation for this change

This code is originally from @volth and split out from #81652. @hedning @jtojnar I believe this is exactly what we talked about doing after the display-manager rewrite PR.

Not sure about changing session options yet #81652 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@worldofpeace
Copy link
Contributor Author

Will add 20.09 notes.

@ofborg ofborg bot added 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: qt/kde 6.topic: xfce The Xfce Desktop Environment 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Apr 12, 2020
@hedning
Copy link
Contributor

hedning commented Apr 12, 2020

Not sure about changing session options yet #81652 (comment)?

Right, I guess it depends somewhat on the semantics of defaultSession. We currently have this:

      Graphical session to pre-select in the session chooser (only effective for GDM and LightDM).

      On GDM, LightDM and SDDM, it will also be used as a session for auto-login.

I think having the session bundled with the autoLogin makes the most sense UI wise. So one option would be to just add a autoLogin.session and make it take priority here:
https://github.com/hedning/nixpkgs/blob/40197cd67c41a8ec6714004dd45db11521d2cb18/nixos/modules/services/x11/display-managers/default.nix#L258-L264

We could then make defaultSession either just do «Graphical session to pre-select in the session chooser (only effective for GDM and LightDM)», or leave it alone. Neither option is super, since the pre-selection thing only works in GDM and LightDM, and the auto-login stuff would be sorta superfluous.

@worldofpeace worldofpeace force-pushed the autologin-unified branch 2 times, most recently from fd2b087 to 3deb31e Compare April 25, 2020 02:08
@worldofpeace
Copy link
Contributor Author

Ok, I've updated the manual (before it didn't build) and added a release note.
As a result of needing to fix the manual, I had to change autoLogin to a submodule.

@worldofpeace
Copy link
Contributor Author

@GrahamcOfBorg test sddm

@ofborg ofborg bot added 8.has: changelog 8.has: documentation This PR adds or changes documentation labels Apr 25, 2020
@worldofpeace
Copy link
Contributor Author

Rebased.

@worldofpeace
nixos/displayManager: make autoLogin options independent of DM type

Verified

This commit was signed with the committer’s verified signature. The key has expired.
Mic92 Jörg Thalheim
GPG key ID: B3F5D81B0C6967C4
Expired
Verified
Learn about vigilant mode
490cd78 
Co-authored-by: volth <volth@volth.com>
@worldofpeace
Copy link
Contributor Author

@GrahamcOfBorg test gnome3

@worldofpeace worldofpeace merged commit 747fb48 into NixOS:master Jul 10, 2020
@worldofpeace worldofpeace deleted the autologin-unified branch July 10, 2020 04:04
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/autologin-appears-in-manual-but-does-not-work/11301/2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: qt/kde 6.topic: xfce The Xfce Desktop Environment 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@worldofpeace @hedning @nixos-discourse @jtojnar