Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/doc: Document breaking change to Haskell dev shells #85085

Merged
merged 1 commit into from Apr 12, 2020
Merged

nixos/doc: Document breaking change to Haskell dev shells #85085

merged 1 commit into from Apr 12, 2020

Conversation

Ericson2314
Copy link
Member

@Ericson2314 Ericson2314 commented Apr 12, 2020 •
edited

Motivation for this change

Close #84070

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/go-no-go-meeting-nixos-20-03-markhor/6495/26

@Ericson2314 Ericson2314 merged commit 923dc61 into NixOS:master Apr 12, 2020
@Ericson2314 Ericson2314 mentioned this pull request Apr 12, 2020
Merged
10 tasks
@Ericson2314 Ericson2314 deleted the document-haskell-env-changes branch April 12, 2020 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: changelog 8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Behaviour of .env in regards to buildDepends changed in 20.03
2 participants
@Ericson2314 @nixos-discourse