Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

discord-{ptb,canary}: update to latest versions and fixup updateScript #85086

Merged
merged 1 commit into from Apr 12, 2020
Merged

discord-{ptb,canary}: update to latest versions and fixup updateScript #85086

merged 1 commit into from Apr 12, 2020

Conversation

bhipple
Copy link
Contributor

@bhipple bhipple commented Apr 12, 2020

This commit:

  • Moves the update script into the dir, out of the maintainers dir. This makes
    it more discoverable in general. It can also be invoked from anywhere to write
    to default.nix
  • Swaps it to use the standardized passthru.updateScript. This means that
    eventually bots like nixpkgs-update will be able to handle it.
  • Runs the script to upgrade to the latest versions

See https://nixos.org/nixpkgs/manual/#ssec-stdenv-attributes

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bhipple
discord-{ptb,canary}: update to latest versions and fixup updateScript
58b812f 
This commit:

- Moves the update script into the dir, out of the maintainers dir. This makes
  it more discoverable in general. It can also be invoked from anywhere to write
  to default.nix
- Swaps it to use the standardized `passthru.updateScript`. This means that
  eventually bots like `nixpkgs-update` will be able to handle it.
- Runs the script to upgrade to the latest versions

See https://nixos.org/nixpkgs/manual/#ssec-stdenv-attributes
@ofborg ofborg bot requested review from ldesgoui, MP2E and tadeokondrak April 12, 2020 16:07
@ryantm ryantm merged commit bd41450 into NixOS:master Apr 12, 2020
@bhipple bhipple deleted the u/discord branch June 2, 2020 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm ryantm approved these changes

@ldesgoui ldesgoui ldesgoui approved these changes

@tadeokondrak tadeokondrak tadeokondrak approved these changes

@jonringer jonringer Awaiting requested review from jonringer

@MP2E MP2E Awaiting requested review from MP2E

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bhipple @ryantm @ldesgoui @tadeokondrak